Skip to content

Add Playwright smoke tests for public uploads - #43

Merged
hhhjin merged 9 commits into
mainfrom
codex/add-playwright-e2e-smoke-tests
Apr 11, 2026
Merged

Add Playwright smoke tests for public uploads#43
hhhjin merged 9 commits into
mainfrom
codex/add-playwright-e2e-smoke-tests

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 11, 2026

Copy link
Copy Markdown
Member

Summary

  • add Playwright config, scripts, CI wiring, and docs for browser E2E runs
  • add public upload smoke coverage for initial load, preview, and anonymous publish flows
  • add stable test ids and dev proxy support for public and raw markdown routes

Verification

  • pnpm lint:fix
  • pnpm test
  • pnpm test:e2e

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Playwright for end-to-end testing, adding a comprehensive test suite, configuration, and data-testid attributes to several components for better selector reliability. Additionally, it refactors the TurnstileWidget to use lazy loading and updates the useUpload hook to handle widget resets via the global window object. Review feedback suggests enhancing test stability by dynamically determining the origin in E2E tests and consolidating redundant proxy rules within the Vite configuration.

Comment thread e2e/public-upload.spec.ts Outdated
Comment thread vite.config.ts
Comment thread vite.config.ts
@hhhjin
hhhjin merged commit 838662b into main Apr 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant