feat: add font size controls to view template - #41
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces font size controls to the view template, allowing users to adjust text size via UI buttons or keyboard shortcuts. The changes include new CSS styles for the controls across multiple themes, a new FontSizeControls component, and client-side logic for font size manipulation. Feedback suggests improving the initialization of the font size index by detecting the actual computed style to avoid unexpected jumps and reconsidering the use of standard browser zoom shortcuts to prevent interference with native accessibility features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing