Skip to content

feat: add font size controls to view template - #41

Merged
hhhjin merged 2 commits into
mainfrom
codex/add-font-size-controls
Apr 6, 2026
Merged

feat: add font size controls to view template#41
hhhjin merged 2 commits into
mainfrom
codex/add-font-size-controls

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • add explicit font size controls to the shared view template top actions
  • wire the controls into the generated client-side script and theme CSS
  • update the template test coverage and regenerate the template hash

Testing

  • pnpm test -- --run shared/templates/tests/view.template.spec.tsx

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces font size controls to the view template, allowing users to adjust text size via UI buttons or keyboard shortcuts. The changes include new CSS styles for the controls across multiple themes, a new FontSizeControls component, and client-side logic for font size manipulation. Feedback suggests improving the initialization of the font size index by detecting the actual computed style to avoid unexpected jumps and reconsidering the use of standard browser zoom shortcuts to prevent interference with native accessibility features.

Comment thread shared/templates/view.template.tsx Outdated
Comment thread shared/templates/view.template.tsx Outdated
@hhhjin
hhhjin merged commit 1d71caf into main Apr 6, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant