Skip to content

feat: add PDF export action in upload flow - #40

Merged
hhhjin merged 2 commits into
mainfrom
codex/add-pdf-export-action
Apr 1, 2026
Merged

feat: add PDF export action in upload flow#40
hhhjin merged 2 commits into
mainfrom
codex/add-pdf-export-action

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 1, 2026

Copy link
Copy Markdown
Member

Summary

  • add a new Create PDF action to the upload form
  • generate printable HTML from parsed markdown using the shared template
  • trigger browser print in a hidden iframe with loading/disabled states
  • add i18n strings for the new PDF action in en/ko/zh/ja

Testing

  • pnpm lint
  • pnpm test -- --runInBand

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a PDF generation and printing feature, adding a 'Create PDF' button to the upload interface along with corresponding translations and state management. The implementation uses a hidden iframe to trigger the browser's print dialog for the rendered markdown. Feedback focuses on enhancing the robustness of the printing utility by addressing a potential memory leak during iframe cleanup and replacing fixed timeouts with callbacks to more accurately manage the generation state.

Comment thread client/routes/index.tsx Outdated
Comment thread client/routes/index.tsx Outdated
@hhhjin
hhhjin merged commit 56050f5 into main Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant