Skip to content

fix: preserve explorer drag overlay sizing - #565

Merged
hhhjin merged 1 commit into
mainfrom
codex/explorer-drag-overlay-sizing
Apr 12, 2026
Merged

fix: preserve explorer drag overlay sizing#565
hhhjin merged 1 commit into
mainfrom
codex/explorer-drag-overlay-sizing

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 12, 2026

Copy link
Copy Markdown
Member

Summary

  • preserve explorer drag overlay width and padding from the dragged row
  • pass the source DOM element into the explorer overlay renderer
  • add tests for the extracted overlay style helper

Validation

  • review gate: no actionable findings
  • pnpm lint:fix
  • pnpm ts:check:desktop
  • pnpm -C apps/desktop test -- src/components/dnd/explorer-drag-overlay.test.tsx

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic styling for the explorer drag overlay by capturing and applying the dimensions and padding of the source element. It adds a sourceElement prop to the ExplorerDragOverlay component, implements a utility function getExplorerDragOverlayStyle to extract styles using getComputedStyle and getBoundingClientRect, and includes corresponding unit tests. I have no feedback to provide as there were no review comments to evaluate.

@hhhjin
hhhjin merged commit e304b24 into main Apr 12, 2026
3 checks passed
@hhhjin
hhhjin deleted the codex/explorer-drag-overlay-sizing branch April 12, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant