refactor: extract editor activation restore - #564
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the editor selection restoration logic into a dedicated utility function, restoreSelectionOnEditorActivate, and introduces unit tests for this logic. The review identifies a regression where the explicit editor focus call was omitted during the refactoring, which would negatively impact the user experience when opening notes. Additionally, there is a suggestion to improve type maintainability by using TypeScript's Parameters utility instead of duplicating the editor type definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review
Testing