Skip to content

refactor: move collection slice into workspace - #559

Merged
hhhjin merged 1 commit into
mainfrom
codex/refactor-workspace-collection-slice
Apr 7, 2026
Merged

refactor: move collection slice into workspace#559
hhhjin merged 1 commit into
mainfrom
codex/refactor-workspace-collection-slice

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 7, 2026

Copy link
Copy Markdown
Member

Summary

  • move collection state and actions into the workspace slice
  • update workspace tree, lifecycle, and fs flows to use workspace-owned collection state
  • relocate collection tests under workspace and remove standalone collection exports

Validation

  • pnpm --filter @mdit/store test
  • pnpm --filter @mdit/store ts:check
  • pnpm ts:check:desktop
  • pnpm test:packages

Review

  • review gate found no actionable issues in the reviewed packages/store scope

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the store by integrating the CollectionSlice directly into the WorkspaceSlice. This involves moving collection-related state and actions into the workspace domain, updating the store configuration in index.ts and core.ts, and adjusting various action creators and tests to reflect the new unified structure. Regarding the feedback, the use of a broad type cast in the setCollectionState helper was noted as a potential area for more specific typing, although it is currently constrained by CollectionStoreState.

Comment thread packages/store/src/workspace/collection/index.ts
@hhhjin
hhhjin merged commit d2b7798 into main Apr 7, 2026
3 checks passed
@hhhjin
hhhjin deleted the codex/refactor-workspace-collection-slice branch April 7, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant