Skip to content

refactor: move tab path sync into store integration - #557

Merged
hhhjin merged 3 commits into
mainfrom
codex/refactor-tab-path-integration
Apr 7, 2026
Merged

refactor: move tab path sync into store integration#557
hhhjin merged 3 commits into
mainfrom
codex/refactor-tab-path-integration

Conversation

@hhhjin

@hhhjin hhhjin commented Apr 7, 2026

Copy link
Copy Markdown
Member

Summary

  • move workspace-owned tab path cleanup, rename, and move side effects into a dedicated store integration
  • emit narrow tab-path events from workspace actions and wire the store to react through registerTabPathIntegration
  • update store action and integration tests to cover delete, rename, move, edit-mode rename, and cross-workspace ignore behavior

Review

  • review gate found no actionable issues in the reviewed store scope

Testing

  • pnpm lint:fix
  • pnpm -C packages/store test

Notes

  • left untracked todos/store-followup-prs.md out of this PR on purpose

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes tab and history synchronization by introducing a registerTabPathIntegration that listens for workspace events, replacing direct port calls in action files. This change ensures that tab paths and history are updated consistently when files are removed, renamed, or moved within a workspace. A bug was identified in the structure-actions.ts fallback logic where the tab history is not updated when a workspace is absent, which could lead to broken navigation.

Comment thread packages/store/src/workspace/fs/structure-actions.ts
@hhhjin
hhhjin merged commit cc8d9b2 into main Apr 7, 2026
3 checks passed
@hhhjin
hhhjin deleted the codex/refactor-tab-path-integration branch April 7, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant