refactor: move tab path sync into store integration - #557
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes tab and history synchronization by introducing a registerTabPathIntegration that listens for workspace events, replacing direct port calls in action files. This change ensures that tab paths and history are updated consistently when files are removed, renamed, or moved within a workspace. A bug was identified in the structure-actions.ts fallback logic where the tab history is not updated when a workspace is absent, which could lead to broken navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerTabPathIntegrationReview
Testing
Notes
todos/store-followup-prs.mdout of this PR on purpose