Skip to content

Dev - #7

Open
hitehsolanki2006 wants to merge 8 commits into
mainfrom
dev
Open

Dev#7
hitehsolanki2006 wants to merge 8 commits into
mainfrom
dev

Conversation

@hitehsolanki2006

Copy link
Copy Markdown
Owner

Description

Please describe what this Pull Request changes, fixes, or adds. Provide background context if necessary.

Related Issues

Links to issues closed/addressed by this PR (e.g., Closes #123 or Fixes #456):


🛠️ Changes Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring or cleanup
  • Documentation update

🧪 Verification & Testing

Describe the tests you ran to verify your changes:

  1. Test Steps: E.g. "Ran Flask backend + Vite React dev server, navigated to Settings panel..."
  2. Expected Result: Describe how it performs and confirm it functions correctly.

📸 Screenshots / Videos (Optional)

If this PR modifies any UI layout, elements, or colors, please paste screenshots or videos showing the changes (e.g., new panel, button hover state, theme change):


✅ Checklist

  • My code follows the code style guidelines of this project.
  • I have ran a local build (npm run build for frontend / tested launch script) and verified it compiles cleanly.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings or console errors.

Comment thread frontend/app.js
<td class="cmd-desc">${cmd.desc}</td>
<td class="cmd-actions">
<button class="cmd-copy-btn" onclick="copyToClipboard(event, '${cmd.cmd.replace(/'/g, "\\'")}')">Copy</button>
<button class="cmd-copy-btn" onclick="copyToClipboard(event, '${cmd.cmd.replaceAll(/'/g, "\\'")}')">Copy</button>
Comment thread frontend/app.js
<div class="script-header">
<span>Setup Script</span>
<button class="script-copy-btn" onclick="copyToClipboard(event, '${day.setup_script.replace(/'/g, "\\'").replace(/\r?\n/g, '\\n')}')">Copy</button>
<button class="script-copy-btn" onclick="copyToClipboard(event, '${day.setup_script.replaceAll(/'/g, "\\'").replaceAll(/\r?\n/g, '\\n')}')">Copy</button>
Comment thread frontend/app.js
<span class="task-title-text">${t}</span>
<div>
<button class="btn btn-ghost btn-xs btn-add-quest" onclick="addRoadmapQuest(event, '${t.replace(/'/g, "\\'")}', ${day.day}, '${day.title.replace(/'/g, "\\'")}')">+ Add Quest Board</button>
<button class="btn btn-ghost btn-xs btn-add-quest" onclick="addRoadmapQuest(event, '${t.replaceAll(/'/g, "\\'")}', ${day.day}, '${day.title.replaceAll(/'/g, "\\'")}')">+ Add Quest Board</button>
Comment thread frontend/app.js
<span class="task-title-text">${t}</span>
<div>
<button class="btn btn-ghost btn-xs btn-add-quest" onclick="addRoadmapQuest(event, '${t.replace(/'/g, "\\'")}', ${day.day}, '${day.title.replace(/'/g, "\\'")}')">+ Add Quest Board</button>
<button class="btn btn-ghost btn-xs btn-add-quest" onclick="addRoadmapQuest(event, '${t.replaceAll(/'/g, "\\'")}', ${day.day}, '${day.title.replaceAll(/'/g, "\\'")}')">+ Add Quest Board</button>
Comment thread frontend/app.js Outdated
Comment thread frontend/arcade.js
@@ -1,3 +1,4 @@
const secureMathRandom = () => (window.crypto ? window.crypto.getRandomValues(new Uint32Array(1))[0] / 4294967296 : Math.random());
Comment thread backend/app.py
filepath = os.path.join(MUSIC_DIR, safe_name)
if not os.path.exists(filepath) or not os.path.isfile(filepath):
filepath = _get_secure_music_path(filename)
if not filepath or not os.path.exists(filepath) or not os.path.isfile(filepath):
Comment thread backend/app.py
filepath = os.path.join(MUSIC_DIR, safe_name)
if not os.path.exists(filepath) or not os.path.isfile(filepath):
filepath = _get_secure_music_path(filename)
if not filepath or not os.path.exists(filepath) or not os.path.isfile(filepath):
Comment thread backend/app.py
filepath = os.path.join(MUSIC_DIR, safe_name)
if not os.path.exists(filepath) or not os.path.isfile(filepath):
filepath = _get_secure_music_path(filename)
if not filepath or not os.path.exists(filepath) or not os.path.isfile(filepath):
Comment thread backend/app.py Dismissed
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
response = requests.get(url, headers=headers, timeout=10, verify=False)
response.raise_for_status()
response = requests.get(url, headers=headers, timeout=10)
Comment thread backend/app.py Fixed
… through an exception'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@hitehsolanki2006 hitehsolanki2006 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants