Skip to content

deps: use sudachipy 0.6.11 for Python 3.14#227

Merged
himkt merged 3 commits into
mainfrom
sudachipy-update
May 4, 2026
Merged

deps: use sudachipy 0.6.11 for Python 3.14#227
himkt merged 3 commits into
mainfrom
sudachipy-update

Conversation

@himkt
Copy link
Copy Markdown
Owner

@himkt himkt commented May 4, 2026

@himkt himkt self-assigned this May 4, 2026
Copilot AI review requested due to automatic review settings May 4, 2026 02:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add Python 3.14 coverage to the project by updating the SudachiPy dependency and extending the CI test matrix. In the context of this codebase, that affects both optional tokenizer dependencies and the repository’s uv-based CI validation path.

Changes:

  • Bump the optional sudachi extra from sudachipy~=0.6.10 to sudachipy~=0.6.11.
  • Add Python 3.14 to the GitHub Actions CI matrix.
  • Keep the rest of the dependency and test setup unchanged.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Updates the Sudachi optional dependency version to target Python 3.14 compatibility.
.github/workflows/ci.yml Expands CI to run the existing checks and tests on Python 3.14.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
]
sudachi = [
"sudachipy~=0.6.10",
"sudachipy~=0.6.11",
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
]
sudachi = [
"sudachipy~=0.6.10",
"sudachipy~=0.6.11",
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@himkt himkt merged commit d76a65f into main May 4, 2026
9 checks passed
@himkt himkt deleted the sudachipy-update branch May 4, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants