Skip to content

Minimal required Node.js version is now 18.20.2.#610

Merged
r37r0m0d3l merged 1 commit into
masterfrom
version/1_2_x
Dec 18, 2025
Merged

Minimal required Node.js version is now 18.20.2.#610
r37r0m0d3l merged 1 commit into
masterfrom
version/1_2_x

Conversation

@r37r0m0d3l

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 16:20
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@r37r0m0d3l r37r0m0d3l merged commit b4baece into master Dec 18, 2025
5 of 9 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the minimum required Node.js version to 18.20.2 and migrates the codebase from JavaScript to TypeScript, along with updating the build tooling from Rollup to Vite/tsup.

  • Migrated all source files from .js to .ts with proper TypeScript type annotations
  • Updated build system from Rollup to Vite and tsup for better TypeScript support
  • Added new hashMulti function and renamed writeJSON to writeJson for consistency

Reviewed changes

Copilot reviewed 122 out of 135 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Updated Node.js version requirement, build dependencies, and scripts
vite.config.mjs New Vite build configuration
tsup.config.ts New tsup configuration for TypeScript builds
tsconfig.json TypeScript compiler configuration with strict type checking
src/index.ts Updated main entry point with new exports including hashMulti
src/core/write/write-json.ts Migrated to TypeScript with renamed function writeJson
src/core/write/write-file.ts Migrated to TypeScript with type annotations
src/core/info/hash-multi.ts New function to calculate multiple hash algorithms
test/index.test.mjs Updated tests to include hashMulti and use renamed writeJson
.travis.yml Updated Node.js and npm versions
CHANGELOG.md Documented version changes and new features
Comments suppressed due to low confidence (4)

test/index.test.mjs:1

  • The test expects remove() to return true, but according to the updated implementation in src/core/remove/remove.ts, the function now returns boolean | Error. When successful, it resolves to true, but the test assertion should handle potential error returns. The previous implementation returned undefined on success.
    test/index.test.mjs:1
  • The test expects remove() to return true for the class method, but this assertion should be consistent with the updated return type of boolean | Error. The previous implementation returned undefined on success.
    src/core/write/write-json.ts:1
  • When configuration.sort is true but configuration.space is not provided, the variable json remains undefined, causing the function to return undefined instead of the stringified JSON. The logic should set json after the sort operation even when space is not specified.
    src/core/error/error-extract-options.ts:1
  • The function has an unreachable return statement at line 24. If the error is an instance of Error but doesn't have the filesystem-specific properties, the function returns nothing (implicitly undefined) rather than { cause: error }. The return at line 24 should be inside an else block or the function should be restructured.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants