chore: depend on upstream mermaid-ascii now that the pkg/graph split is merged - #27
Merged
Conversation
…is merged AlexanderGrooff/mermaid-ascii#94 landed on master, so the replace directive pointing at the hidekingerz fork is gone and go.mod names the upstream merge commit. The maintainer plans a tagged release that includes the new public packages; this can move to that tag then. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KUYF9hXeZFML1s8r3i2RVX
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlexanderGrooff/mermaid-ascii#94 (moving the graph renderer and
RenderDiagramout ofcmd) was merged upstream, with the maintainer noting the public-API additions will go into a new release. This drops thereplacedirective that pointedgo.modat thehidekingerz/mermaid-asciifork and depends on upstream's merge commit8baafe6directly. No code changes; the binary is byte-for-byte the same size.When upstream tags the release, a follow-up can pin that tag instead of the pseudo-version.
Test plan
gofmt -l .,go vet ./...,TMPDIR=/tmp go test -race ./...cleango.modhas noreplace, no cobra or gin in the module graph, binary 17.0 MB as before🤖 Generated with Claude Code
https://claude.ai/code/session_01KUYF9hXeZFML1s8r3i2RVX