fix: show a flowchart with non-ASCII text as source instead of mojibake - #25
Merged
Conversation
The flowchart renderer in mermaid-ascii places text byte by byte, so a Japanese node or edge label came out as three broken cells per character. Until it handles runes, a flowchart or graph whose source is not all ASCII stays as source. The sequence renderer measures text by display width and keeps drawing such labels. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KUYF9hXeZFML1s8r3i2RVX
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A flowchart with a Japanese node name or edge label (
A[開始],-->|はい|) was drawn as mojibake: mermaid-ascii's flowchart renderer (pkg/graph,drawText) places text byte by byte, so each multi-byte character became three broken cells. The sequence renderer measures text withrunewidthand is unaffected.internal/ui/mermaid.go: aflowchart/graphblock whose source is not all ASCII is left as source, like a block that cannot be drawn. Other diagram types are unchanged.Upstream fix (rune- and width-aware placement in
pkg/graph) is the real solution; this keeps the output readable until then.Test plan
gofmt -l .,go vet ./...,TMPDIR=/tmp go test -race ./...clean🤖 Generated with Claude Code
https://claude.ai/code/session_01KUYF9hXeZFML1s8r3i2RVX