Automatically close tab after 5 seconds - #95
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for sharing
That's unexpected, unless each repository has a different user or host. What's your config? |
|
My git configuration is a bit more elaborated. I have multiple |
|
Curious. I'd expect at most one tab opened in six hours (21600 seconds). Try #77 (comment) Try this troubleshooting section https://github.com/hickford/git-credential-oauth/blob/main/README.md#troubleshooting and debugging https://github.com/hickford/git-credential-oauth/blob/main/README.md#debugging |
|
This is really weird. I tried simplifying my git config but could not get rid of the multiple tabs. I wonder if this is rather related to vscode which performs Thanks for your support! BTW, I love this project. Great work! |
|
What platform and Git version are you using? |
|
I am on WSL (Windows 11) with git 2.51.0. If I visit multiple git repositories and run |
|
So you have Git installed inside WSL as well as Git for Windows outside? That's typical but check both configurations. VSCode installed in Windows presumably? Then it would use Git for Windows. |
|
I am using VSCode with the WSL extension so the server side component is running in WSL and all git commands are executed in WSL. I am sure that it is related to Thanks for your support. The reason for this PR has changed. It is now more of a luxury feature if the tab goes away automatically. cosign does this for example. I'll update the description. |
the call site in main() exits on error, so this seems unnecessary here
use package rsc.io/qr to generate QR codes and display them in the terminal using ANSI escape codes.
github gists under gist.github.com are just git repos that share the same auth infrastructure as the normal github.com instance, so we can just reuse the existing github.com configuration there
as github gists use the normal github endpoints they should be excampt of the domain matching test
Couple of preallocations for maps that can be done, plus making `template` a `const`
Improvement for hickford#79
4aac7d8 to
c47aaf0
Compare
|
@hickford is there a chance this will get merged? If not, are there other ways to establish this kind of functionality you will be willing to accept (E.g, a config variable to customize the page template) |
This change automatically closes the tab after 5 seconds. This is just for convenience.