fix: skip encode timestamp queries on unsupported queues - #28
Merged
Conversation
schlegp
force-pushed
the
fix/radv-timestamp-bug
branch
from
July 28, 2026 11:35
b84a9e4 to
0997f1f
Compare
schlegp
marked this pull request as ready for review
July 28, 2026 11:39
Contributor
|
Seems to be a |
Contributor
Author
|
@DatCaptainHorse Do you use a RDNA4 GPU? If so, could you check if this fix works for you aswell? |
hgaiser
reviewed
Jul 28, 2026
Owner
There was a problem hiding this comment.
It seems this is safe with a null pointer, but should it be guarded by an if statement regardless?
Contributor
Author
There was a problem hiding this comment.
Thanks, have placed it behind a guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running hgaiser/moonshine#116 against the latest pixelforge main was crashing on AMD RX 7900XTX with RADV.
Turns out, RADV does not support timestamps on the encode queue family.
This PR checks the reported timestamp capabilites during device selection and gates the functionality behind that.