fix(windows): add PowerShell continuation fallback and docs#2
Open
advancegabrielguihurt wants to merge 2 commits into
Open
fix(windows): add PowerShell continuation fallback and docs#2advancegabrielguihurt wants to merge 2 commits into
advancegabrielguihurt wants to merge 2 commits into
Conversation
Cursor caps followup_message chains at 5 unless loop_limit is null. The previous macOS-only osascript workaround silently failed on Linux at iteration 5, stopping the loop. - Add hooks/hooks.json.example with loop_limit: null - Simplify stop hook to always emit followup_message - Add optional continue-linux.sh keyboard fallback for legacy configs - Document Linux requirements in README and ralph command Co-authored-by: Cursor <cursoragent@cursor.com>
Windows installs failed for the same reason as Linux: the stop hook relied on macOS osascript after 5 iterations. The loop_limit: null fix (included from the Linux PR) is the primary path. This commit adds continue-windows.ps1 for legacy configs that cannot set loop_limit, plus Windows hook path and Git Bash requirements. Co-authored-by: Cursor <cursoragent@cursor.com>
|
I'm really sorry about this, I know this can become really annoying. I asked Composer to make some fixes for Windows and Linux, and it assumed my mention of different PR's meant I wanted them created and pushed. 2.5 is so fast by the time I thought I should fork the repo first to test the changes locally, I looked up and saw it was creating the PR's already. Please feel free to close both this and the related PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows had the same failure mode as Linux: the original stop hook depended on macOS
osascriptafter 5 iterations.This PR includes the
loop_limit: nullfix from #1 (required on Windows too) and adds Windows-specific support:hooks/continue-windows.ps1— optional PowerShellSendKeysfallback for legacy configs that cannot setloop_limit: nulljqinstall, hook path conventions, known Hooks Execution Log quirkMerge order
Merge #1 first, then this PR (or rebase onto master after #1 lands). This branch contains the Linux commit plus the Windows commit.
Test plan
loop_limit: nullin.cursor/hooks.jsonjqis available in Git Bash/ralph-loopwith--max-iterations 8and confirm iterations continue past 5continue-windows.ps1only if validating legacy fallback withoutloop_limit: nullMade with Cursor