fix(tocObj): extract semantic math text - #448
Open
stevenjoezhang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Description
Fixes duplicate or incorrect TOC text when headings contain math rendered by KaTeX or other MathML-based renderers.
KaTeX outputs both an accessible MathML representation and a visual HTML representation.
DomUtils.textContent()concatenated both branches, causing formulas to appear multiple times in generated TOC entries.This change adds semantic text extraction that:
aria-hidden="true"orhidden<semantics>No additional math-rendering dependency is introduced.
Additional information
To test:
npm test(260 passing)npm run eslinthexo-utilon Node.js 24 (1278 passing,5 pending)Energy E=mc^2appears only once in the generated TOCFixes #447