Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Add support for the private space sydney - #110

Open
drusellers wants to merge 2 commits into
heroku:masterfrom
drusellers:new-regions
Open

Add support for the private space sydney#110
drusellers wants to merge 2 commits into
heroku:masterfrom
drusellers:new-regions

Conversation

@drusellers

Copy link
Copy Markdown

Closes #109

@drusellers

Copy link
Copy Markdown
Author

bump

@drusellers

Copy link
Copy Markdown
Author

add support for dublin now too

@mathias

mathias commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Hello! Have you tried https://github.com/heroku/heroku-cli-addons-admin ? Kensa is mostly deprecated, and I'd like to close this PR if the new CLI plugin works for you.

@drusellers

Copy link
Copy Markdown
Author

@mathias hello, we currently use kensa to validate our own internal API and that it is correctly respecting the contract of Heroku. These new commands are quite nice, and we look to integrate this into our CI flow but it doesn't help us with the correction around API calls. Does that make sense?

@mathias

mathias commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Hello @drusellers ,

Yes, the new plugin doesn't have any testing built in. We found that we could not maintain integration testing for every way that add-ons can be used, with the Platform API for Partners and new features like async provisioning, etc.

Instead, we ask that add-on partners write their own integration tests into their codebase's test suite based on our Dev Center docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants