Update drifted schemas#164
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the JSON schemas to match current (“drifted”) configuration structures used by the Hiro systems, aligning schema validation with the Go/proto model.
Changes:
- Extend the Auctions schema to include
item_countsmaps in bid-related structures and add theimmediate_buyoutboolean flag. - Tighten the Leaderboards schema by changing
duration,start_time_sec, andend_time_secfromnumbertointeger(matching theint64model types).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| schemas/16-Hiro-Auctions.json | Adds item_counts and immediate_buyout to better reflect Auctions config types. |
| schemas/06-Hiro-Leaderboards.json | Changes time-related fields to integer to match the Leaderboards config model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tolgatolgay
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.