Extend auction system with item bidding, instant complete, and directed auctions#158
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the auction system’s API/contracts to support item-based bidding, directed (invite-only) auctions, and an “instant complete” (buyout-triggered completion) behavior across templates and auction instances.
Changes:
- Expanded
AuctionBidAmountto support item requirements/offers viaitem_counts,instance_ids, and resolveditems. - Added “instant complete” behavior flags to auction templates and auctions, and added directed-auction visibility controls (
allowed_user_ids,directed_at_me). - Updated Go auctions system config and public interface signatures to expose the new filtering/creation capabilities.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| hiro.proto | Extends auction/bid/claim/list/create messages to add item bidding, instant-complete, and directed-auction fields. |
| hiro-openapi.yml | Mirrors the proto contract additions in the OpenAPI schemas for clients/codegen. |
| auctions.go | Adds new config fields and updates the public AuctionsSystem interface to accept directed-auction parameters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sesposito
left a comment
sesposito
left a comment
There was a problem hiding this comment.
Left a couple of naming suggestions, @tolgatolgay and @novabyte wdyt on these naming changes?
| // User IDs of directed users that are allowed to see and bid on this auction, if any. | ||
| repeated string allowed_user_ids = 31; | ||
| // Whether the auction should be immediately completed if a bid meets the buyout price. | ||
| bool instant_complete = 32; |
There was a problem hiding this comment.
Perhaps immediate_buyout could be more descriptive?
| // Cursor to use for retrieving the next page of results. | ||
| string cursor = 4; | ||
| // If true, only returns auctions that the user is directly allowed to see and bid on, by being included in the allowed users list for directed auctions. | ||
| bool directed_at_me = 5; |
There was a problem hiding this comment.
allowed_only maybe plays better with the counterpart allowed_user_ids?
There was a problem hiding this comment.
I think direct_trade or allowed_for_direct_trade will be a better naming.
There was a problem hiding this comment.
I think it's better to avoid mentioning direct trade because technically this can be used for things like team's only auction and friends auction and not just direct trades, so going for allowed_only
Calm0
force-pushed
the
nabil-extend-auction-system
branch
from
42c445d to
8bb0f2f
Compare
No description provided.