MINOR: adding Reader/Writer std::optional variants, same as boost::op…#258
Open
epavese wants to merge 2 commits intoheremaps:masterfrom
Open
MINOR: adding Reader/Writer std::optional variants, same as boost::op…#258epavese wants to merge 2 commits intoheremaps:masterfrom
epavese wants to merge 2 commits intoheremaps:masterfrom
Conversation
Collaborator
|
Can you also add a test to You also need to sign the DCO (see https://github.com/heremaps/flatdata/pull/258/checks?check_run_id=71083619761) |
added 2 commits
April 13, 2026 16:28
…tional ones Signed-off-by: Esteban Pavese <esteban.pavese@here.com>
Signed-off-by: Esteban Pavese <esteban.pavese@here.com>
epavese
force-pushed
the
std_optional_variants
branch
from
5a96061 to
cfef398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.