fix: prevent sending string 'null' or 'undefined' tokens to backend (Issue #257)#305
Closed
basantnema31 wants to merge 1 commit into
Closed
fix: prevent sending string 'null' or 'undefined' tokens to backend (Issue #257)#305basantnema31 wants to merge 1 commit into
basantnema31 wants to merge 1 commit into
Conversation
|
@basantnema31 is attempting to deploy a commit to the swapnilsingh99's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @basantnema31! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #257
The Bug:
Whenever
localStoragegets corrupted or improperly set,getItem("token")can return the literal strings "null" or "undefined". The truthiness checkif (!token)evaluates these strings astrue, causing the frontend to send a request to the backend withAuthorization: Bearer null. The backend crashes when trying to parse this invalid token data, preventing the frontend page from rendering.The Fix:
Updated
UserContext.jsxto explicitly check for and catch the string variants of "null" and "undefined", correctly intercepting the bad state and forcing the user to the login screen instead of crashing the backend connection.