fix: restrict populated author fields to prevent leaking sensitive data (Issue #265, #271)#303
Closed
basantnema31 wants to merge 1 commit into
Closed
Conversation
|
@basantnema31 is attempting to deploy a commit to the swapnilsingh99's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @basantnema31! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #265, Fixes #271
The Bug:
Whenever a user requested notes, questions, or requests, the backend was populating the
authorfield with the entireUserdocument. This unintentionally exposed highly sensitive user data to the client, including hashed passwords, OTPs, email addresses, and account settings.The Fix:
Modified the
populate("author")calls innote.controller.js,question.controller.js, andrequest.controller.jsto explicitly select only safe fields:.populate("author", "username userPhoto"). This significantly reduces the payload size and completely closes the security vulnerability.