fix: suppress transient elevated Windows terminal titles - #2433
Open
Pimpmuckl wants to merge 3 commits into
Open
fix: suppress transient elevated Windows terminal titles#2433Pimpmuckl wants to merge 3 commits into
Pimpmuckl wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Pimpmuckl
force-pushed
the
fix/normalize-elevated-terminal-titles
branch
from
August 6, 2026 18:04
8288a7b to
c5a7303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While dogfooding Herdr on native Windows, I noticed pane titles briefly flashing
Administrator: ...whenever Codex ran a nested PowerShell tool process.Windows temporarily rewrites the inherited console title from
<current title>toAdministrator: <current title>and restores it when the process exits. ConPTY emits both changes as title OSC events, and Herdr currently publishes the intermediate title immediately.In 10 observed runs, the decoration appeared 51–78 ms after the stable title and disappeared 54–84 ms later.
Fix
On Windows, hold only the exact transition from
<current title>toAdministrator: <current title>for 200 ms.The Windows-specific classification stays in
src/platform/windows.rs; the shared terminal state only handles the generic settle/cancel/promote behavior.Scope
Administrator:titles still appear after 200 msValidation
just checkpasses on native Windows after rebasing onto currentmasterAdministrator:titles