fix(theme): refresh host appearance on focus

[akbash-bot]

Summary

• query the host's Mode 2031 appearance when outer focus returns
• keep appearance queries separate from OSC color refreshes to avoid feedback
• preserve the behavior in both normal client/server mode and --no-session

Checks

• cargo test outer_focus_gained_requests_host_appearance_query
• cargo test write_host_terminal_appearance_query_emits_mode_2031_query
• cargo test write_host_terminal_theme_query_emits_osc_queries
• just ci 'all() - test(live_server_holds_one_pty_master_fd_per_pane)' (3236 tests passed; excluded test also fails unchanged on origin/master in the nested Kennel environment)
• just windows-lint
• maintenance unittest suite (93 tests)

refs #2416

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f3cd186b-6d6a-459f-825a-f78e02085753

📥 Commits

Reviewing files that changed from the base of the PR and between b2ee467 and a0c57e2.

📒 Files selected for processing (1)

• src/raw_input.rs

---

📝 Walkthrough

Walkthrough

The runtime now queries host terminal appearance on non-Windows platforms when outer focus is gained. Input framing detects focus events, emits \x1b[?996n, and handles bounded replies. Tests cover query separation, focus behavior, reply reassembly, and timeouts.

Changes

Host terminal appearance query

Layer / File(s)	Summary
Appearance query contract and input framing src/terminal_theme.rs, src/raw_input.rs, src/client/input.rs	Defines the host appearance query sequence and enables bounded reply handling for OuterFocusGained on supported platforms.
Appearance query emission and runtime wiring src/app/theme_sync.rs, src/app/runtime.rs, src/client/mod.rs	Writes and flushes the query sequence. Client and runtime input handling trigger the query when appearance refresh is required.
Query separation and reply handling tests src/client/mod.rs, src/raw_input.rs	Tests query output, separation from terminal theme queries, focus detection, reply reassembly, disabled handling, and timeout behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

• bug: host terminal appearance is not re-queried when outer focus is gained #2416: The changes implement the issue’s fix for querying host terminal appearance on OuterFocusGained.

Possibly related PRs

• herdrdev/herdr#2160: Both PRs modify host-query tracking and stdin framing in src/client/input.rs and src/raw_input.rs.
• herdrdev/herdr#2285: Both PRs detect focus-gained events in src/raw_input.rs and trigger client-side terminal actions.

Sequence Diagram(s)

sequenceDiagram
  participant Runtime
  participant Client
  participant HostInputReader
  participant Terminal
  Runtime->>Client: Handle OuterFocusGained
  Client->>Terminal: Write and flush appearance query
  Terminal-->>HostInputReader: Return appearance reply
  HostInputReader->>HostInputReader: Buffer and parse bounded reply

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: refreshing host terminal appearance when focus returns.
Description check	✅ Passed	The description directly explains focus-triggered appearance queries, separation from OSC refreshes, preserved modes, and validation checks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch akbash/2416-refresh-appearance-on-focus

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[greptile-apps]

Greptile Summary

The PR refreshes the host terminal’s Mode 2031 appearance when outer focus returns while keeping appearance queries separate from OSC color refreshes.

• Adds focused-host appearance queries in client/server and no-session paths.
• Arms bounded raw-input reply framing before focus-triggered responses can arrive.
• Retains split appearance CSI fragments for an additional idle-flush interval.
• Adds regression coverage for query emission, disabled policy, split replies, and timeout behavior.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
src/raw_input.rs	Arms focus-triggered appearance replies before delivery and preserves expected split CSI prefixes for one bounded additional flush.
src/client/input.rs	Enables focus-query reply framing on the Unix client input path when host theme protocols are active.
src/client/mod.rs	Emits a dedicated host appearance query on focus and keeps it separate from OSC theme queries.
src/app/runtime.rs	Refreshes host appearance on focus in the normal app/no-session runtime path.
src/app/theme_sync.rs	Adds the non-Windows stdout writer for the dedicated appearance query.
src/terminal_theme.rs	Defines the fixed Mode 2031 appearance-query sequence used by both runtime paths.

_{Reviews (4): Last reviewed commit: "Merge branch 'master' into akbash/2416-r..." | Re-trigger Greptile}