Skip to content

[Snyk] Security upgrade idna from 3.10 to 3.15#38

Open
henols wants to merge 1 commit into
mainfrom
snyk-fix-523ebb459084c7b6adb0d0567b01bbea
Open

[Snyk] Security upgrade idna from 3.10 to 3.15#38
henols wants to merge 1 commit into
mainfrom
snyk-fix-523ebb459084c7b6adb0d0567b01bbea

Conversation

@henols
Copy link
Copy Markdown
Owner

@henols henols commented May 20, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • requirements.txt
⚠️ Warning
equests 2.31.0 requires idna, which is not installed.
requests 2.31.0 requires urllib3, which is not installed.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-IDNA-16769942
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates requirements.txt to pin idna and urllib3 to specific versions to address vulnerabilities. However, the specified versions do not exist on the public PyPI registry, which will cause installation failures; the reviewer suggested using the correct stable versions instead.

Comment thread requirements.txt
Comment on lines +7 to +8
urllib3>=2.6.3 # not directly required, pinned by Snyk to avoid a vulnerability
idna>=3.15 # not directly required, pinned by Snyk to avoid a vulnerability No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The versions specified for idna (3.15) and urllib3 (2.6.3) do not appear to exist on the public PyPI registry. The latest stable versions are 3.10 and 2.2.2 respectively. Specifying non-existent versions will cause pip install to fail, which is likely the cause of the warnings mentioned in the pull request description regarding these packages not being installed.

I have suggested the correct stable versions and included a trailing newline for the file.

urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
idna>=3.10 # not directly required, pinned by Snyk to avoid a vulnerability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants