docs(notediscovery): sync 0.28.1 default#381
Conversation
📝 WalkthroughWalkthroughAdds an Image Tag field to the qdrant playground config. Updates NoteDiscovery docs to pin image version 0.28.1 and adds upgrade notes about release changes and storage-path behavior. ChangesConfig and Docs Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: documentation, enhancement Suggested reviewers: None identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/data/playground-configs.ts`:
- Around line 5156-5162: The Image Tag control is currently defined in
langflow-specific playground config even though its default and description are
NoteDiscovery-specific. Move the image.tag field from the langflow configuration
in playground-configs to the NoteDiscovery chart/config section, and ensure the
NoteDiscovery playground uses the same key with its matching metadata so the
control appears under the correct chart.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ccbaede8-b0dc-4773-8825-6809243385c5
📒 Files selected for processing (2)
src/data/playground-configs.tssrc/pages/docs/charts/notediscovery.mdx
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/data/playground-configs.ts (1)
8747-8753: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winMisplaced Image Tag field: added to
qdrant, but description/default are NoteDiscovery-specificThis field's label, default (
0.28.1), and description ("Pinned NoteDiscovery image tag") all reference NoteDiscovery, not Qdrant. Meanwhile, thenotediscoverychart's General section (lines 8936-8962) has noimage.tagfield. This mirrors a previously flagged and supposedly-fixed issue where this same field was misplaced underlangflow; it appears to have resurfaced underqdrantinstead of landing innotediscovery.🐛 Proposed fix: move the field to the notediscovery chart
qdrant: [ { name: 'General', fields: [ - { - label: 'Image Tag', - key: 'image.tag', - type: 'text', - default: '0.28.1', - description: 'Pinned NoteDiscovery image tag', - }, { label: 'HTTP Port', key: 'app.port',notediscovery: [ { name: 'General', fields: [ + { + label: 'Image Tag', + key: 'image.tag', + type: 'text', + default: '0.28.1', + description: 'Pinned NoteDiscovery image tag', + }, { label: 'HTTP Port', key: 'app.port',🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/data/playground-configs.ts` around lines 8747 - 8753, The Image Tag field is misplaced in the qdrant config even though its label, default, and description are NoteDiscovery-specific. Move the `image.tag` entry out of the qdrant section in `playground-configs` and add it to the `notediscovery` chart’s General configuration, keeping the existing NoteDiscovery label/default/description there. Use the `image.tag` field definition and the qdrant/notediscovery chart sections to relocate it correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@src/data/playground-configs.ts`:
- Around line 8747-8753: The Image Tag field is misplaced in the qdrant config
even though its label, default, and description are NoteDiscovery-specific. Move
the `image.tag` entry out of the qdrant section in `playground-configs` and add
it to the `notediscovery` chart’s General configuration, keeping the existing
NoteDiscovery label/default/description there. Use the `image.tag` field
definition and the qdrant/notediscovery chart sections to relocate it correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b54bb50d-bb41-4caa-8b40-5ec4cd237097
📒 Files selected for processing (1)
src/data/playground-configs.ts
Closes #700. ## Summary - Bump NoteDiscovery from `0.27.3` to `0.28.1`. - Update chart defaults, values schema, unittest expectations, README, and design docs. - Document the 0.28.x large-vault indexing/storage path changes and keep the chart storage contract stable through `persistence.mountPath`. ## Upstream Evidence - GitHub release: https://github.com/gamosoft/NoteDiscovery/releases/tag/v0.28.1 - Release status verified with GitHub CLI: not draft, not pre-release, published `2026-07-06T07:59:01Z`. - Docker image manifest verified: `ghcr.io/gamosoft/notediscovery:0.28.1`. - Manifest platforms: `linux/amd64`, `linux/arm64`. - Upstream notes: `0.28.0` adds the large-vault in-memory note index, background warmup, faster search/graph/stats paths, and configurable `NOTES_DIR`/`PLUGINS_DIR`; `0.28.1` fixes task rendering. ## Site Sync - Site PR: helmforgedev/site#381 ## Validation - `make image-verify IMAGE=ghcr.io/gamosoft/notediscovery:0.28.1` - `make deps-check CHART=notediscovery` - `helm unittest charts/notediscovery` passed: 8 suites, 33 tests. - `make standards-check CHART=notediscovery` - `node scripts/charts/template-standards-check.js --chart notediscovery` - `make validate-chart CHART=notediscovery` passed fully: 19 layers, including k3d behavioral validation for default plus all CI values scenarios. - `make site-sync-check CHART=notediscovery` - `make release-check REPO=charts` - `make attribution-check REPO=charts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated the bundled NoteDiscovery version to 0.28.1 across the Helm chart and default image settings. * **Documentation** * Revised setup and design docs to reference the newer image version. * Added upgrade notes with guidance for safer upgrades, including storage consistency and backup recommendations. * **Tests** * Updated chart tests to expect the new pinned image version. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: MergeCheck <mergecheck@example.invalid>
Summary
0.28.1.Validation
make site-sync-check CHART=notediscoverynpm run format:checknpm run lintnpm run buildmake release-check REPO=sitemake attribution-check REPO=siteSummary by CodeRabbit
New Features
Documentation