Feature/upright camera view - #30
Open
hello-sanchez wants to merge 25 commits into
Open
Conversation
…ckage to rotate camer view upright.
…age to rotate camer view upright.
…age to rotate camer view upright.
…age to rotate camer view upright.
…o define an image topic they wish to rotate upright.
…e for the image rotation.
… upright camera view launch file in the gazebo.launch file.
hello-binit
reviewed
Sep 7, 2021
hello-binit
reviewed
Sep 7, 2021
| <remap from="rotated/image" to="$(arg image_topic)_upright_view"/> | ||
| </node> | ||
|
|
||
| <!--- Run dynamic_reconfigure node to set target_z to -1.0. This rotates the image_raw upright.--> |
Contributor
There was a problem hiding this comment.
Can you set these parameters directly instead of using dynamic reconfigure?
hello-binit
requested changes
Sep 7, 2021
hello-binit
left a comment
hello-binit
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @hello-sanchez. Looks like image_pipeline and image_rotate are already binaries (ros-noetic-image-rotate). Can you remove the git submodule, and add the dependency to package.xml?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch also includes the pipeline_image package as a submodule. It is in the deps folder.
I've created a launch file, upright_camera_view.launch, which runs the image_rotate node and the parameters to rotate the camera feed upright. This launch file and its argument are also included in the original gazebo file.