V8 recovery from bad javascript#516
Closed
dpezely wants to merge 3 commits into
Closed
Conversation
macpie
reviewed
Nov 19, 2021
Contributor
Author
|
Superseded by PR #528 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an adventure through the wilderness of V8 things... (stories for another time), there are zero changes to
erlang_v8that would be required for this. (However, there are additional tests in a PR there demonstrating the V8 behavior.)Instead, the idea is for
routerhandling the entire burden of ambiguous V8 errors and recovering from them by restarting the V8 VM.From where this branch was made, merging this would also restore Pierre's feature of backoff & retry. (That set of features was partially reverted and augmented by @michaeldjeffrey's merge of commit,
6852b94fa, which could be cleanly reversed if we decide to go that direction.)QUESTION: how to proceed with the merge? It's probably best to essentially rebase this branch to current HEAD on
master, but do we stick with current retry logic, or reinsert use of thebackofflibrary?Heart of the matter at hand:
V8 errors as available via
erlang_v8offers insufficient granularity. Fixing that requires reaching beyond the C++ Erlang Port to resolve. However, V8 docs don't easily accommodate cherry-picking one's way through for our purposes here.OPERATIONAL NOTE:
Track repeat offenders of bad JS code via external monitoring.
Look for log entry with this RegEx pattern: