Skip to content

feat: add payment scope support#44

Open
colombefioren wants to merge 24 commits into
preprodfrom
feat/scope
Open

feat: add payment scope support#44
colombefioren wants to merge 24 commits into
preprodfrom
feat/scope

Conversation

@colombefioren

@colombefioren colombefioren commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • add scope field to Payment, JPayment and JPaymentMapper
  • add scope param to createPayment() method in repository, plus jpql queries for filtered pagination, counting, aggregation and distinct scope retrieval via findDistinctScopes() that will be consumed by the UI
  • expose scope aware filtering methods in PaymentService
  • add new migration file for that scope addition in payment table
  • expose findAll() in ApplicationRepository for app fetching that will be consumed by PaymentViewController for the app dropdown
  • add necessary tests for those changes

@colombefioren
feat: add scope field to Payment domain and JPA entity
62d4984
@colombefioren
feat: propagate scope through repository layer with JPQL queries
81311f4
@colombefioren
feat: expose scope filtering in PaymentService methods
d44ce5f
@colombefioren
feat: add database migration for scope column
c5e27d9
@colombefioren
refactor: extract nullIfAll helper for scope filter methods
738e1d6
@colombefioren
feat: update existing tests for scope param and add scope filtering t…
79b9b08 
…ests
@colombefioren
feat: replace scope arg with meaningful names and fix existing tests
d7f3d1a
@colombefioren
feat: use null instead of placeholder for non-scoped tests
1f6c011
@colombefioren
feat: add general service tests for findPaymentsByApplicationName and…
8e6bda7 
… date range
@colombefioren
feat: add optional scope param to POST /payment endpoint
b8811f2
@colombefioren
fix: add missing scope arg to second Payment constructor in test
102ef38
@colombefioren
fix: add p.scope to native query SELECT in JPaymentRepositoryCustomImpl
fc4fc4c
@colombefioren
chore: update test date
f4618a0
@colombefioren
chore: change test data ref
5fd22ad
@colombefioren
feat: add test for findAllPayments, sumAmountForSucceeded, countPending
b932742
@colombefioren
refactor: resolve blank line conflict
7696eab
hei-teacher
hei-teacher requested changes Jul 10, 2026
View reviewed changes
Comment thread src/main/java/school/hei/vola/repository/jpa/JApplicationRepository.java Outdated
Comment thread src/main/java/school/hei/vola/repository/jpa/JPaymentRepository.java
Comment thread src/main/java/school/hei/vola/repository/jpa/JPaymentRepository.java Outdated
Comment thread src/main/java/school/hei/vola/repository/jpa/JPaymentRepository.java
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
hei-teacher
hei-teacher requested changes Jul 11, 2026
View reviewed changes
Comment thread src/main/java/school/hei/vola/repository/PaymentRepository.java Outdated
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
Comment thread src/main/java/school/hei/vola/service/PaymentService.java Outdated
Comment thread src/test/java/school/hei/vola/service/PaymentServiceIT.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hei-teacher hei-teacher Awaiting requested review from hei-teacher

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colombefioren @hei-teacher @NickyHariniaina