feat: filter student grades by academic year level#903
Open
tendryAxel wants to merge 4 commits into
Open
Conversation
tendryAxel
force-pushed
the
feat/filter-student-grades-by-academic-year-level
branch
from
105de6b to
3205ea7
Compare
Mahefaa
requested changes
May 30, 2025
Comment on lines
+98
to
+99
| Period.between(LocalDate.from(this.getPromotion().getStartDatetime()), localDate) | ||
| .getYears(); |
Member
There was a problem hiding this comment.
i think we've had some bugs concerning this, like not knowing the exact promotion at a certain time
Member
There was a problem hiding this comment.
you're not testing your new filter at all
kirisaki-vk
force-pushed
the
preprod
branch
2 times, most recently
from
4cff246 to
2efe473
Compare
kirisaki-vk
force-pushed
the
preprod
branch
2 times, most recently
from
25800ee to
6f13992
Compare
kirisaki-vk
force-pushed
the
preprod
branch
from
94af8d8 to
f3d9459
Compare
kirisaki-vk
force-pushed
the
preprod
branch
2 times, most recently
from
8da7732 to
e78b273
Compare
DyferHerioss
force-pushed
the
preprod
branch
from
c0483de to
fa94df3
Compare
Mbomain
force-pushed
the
preprod
branch
2 times, most recently
from
3ef4497 to
695add5
Compare
DyferHerioss
force-pushed
the
preprod
branch
3 times, most recently
from
0fe2cab to
c095093
Compare
DyferHerioss
force-pushed
the
preprod
branch
7 times, most recently
from
15855a1 to
9ed506e
Compare
DyferHerioss
force-pushed
the
preprod
branch
2 times, most recently
from
6d96245 to
874f2d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.