Skip to content

fix: get student repeating year#1252

Open
DyferHerioss wants to merge 28 commits into
preprodfrom
fix/grades-for-student-repeating-year
Open

fix: get student repeating year#1252
DyferHerioss wants to merge 28 commits into
preprodfrom
fix/grades-for-student-repeating-year

Conversation

@DyferHerioss

Copy link
Copy Markdown
Collaborator

No description provided.

@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from c056fd6 to 6afc834 Compare June 24, 2026 11:31

@tokyramarozaka tokyramarozaka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when the refactor is done, I'll co-code on the branch with you later on.

Comment thread src/main/java/school/hei/haapi/repository/UserRepository.java Outdated
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/test/java/school/hei/haapi/service/GradeResultServiceTest.java Outdated
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from 0bc380d to b926005 Compare June 25, 2026 06:44
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from e3038de to 6a31a53 Compare June 25, 2026 07:59
@DyferHerioss DyferHerioss force-pushed the preprod branch 2 times, most recently from 6d96245 to 874f2d5 Compare July 2, 2026 13:19
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from c07bc47 to 183daed Compare July 9, 2026 11:24
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from b60e932 to 4ef2166 Compare July 9, 2026 12:05
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from 4ef2166 to 958967e Compare July 9, 2026 12:29
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from 958967e to 98678f4 Compare July 9, 2026 14:19
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from 4cee6e1 to ac61ac6 Compare July 10, 2026 11:04
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch 2 times, most recently from 79dbccf to dcd48fb Compare July 10, 2026 11:16
@DyferHerioss DyferHerioss force-pushed the fix/grades-for-student-repeating-year branch from dcd48fb to 4b47c21 Compare July 10, 2026 11:18

@tokyramarozaka tokyramarozaka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most important change are mostly the user service injecting itself.

Comment thread src/main/java/school/hei/haapi/endpoint/rest/controller/GradeController.java Outdated
Comment thread src/main/java/school/hei/haapi/repository/ExamRepository.java
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java
Comment thread src/main/java/school/hei/haapi/service/CourseResultService.java Outdated
Comment thread src/main/java/school/hei/haapi/service/UserService.java Outdated
Comment thread src/test/java/school/hei/haapi/integration/GradeIT.java Outdated
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

💡 Need a hand with PR review? Try Gitar by Sonar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants