fix: reject JWTs with out-of-bounds expiration values to prevent time.Time overflow [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #5
Open
waterWang wants to merge 1 commit into
Conversation
….Time overflow Added validation in the validator to check that exp, nbf, and iat claims contain numeric values within safe bounds for conversion to Go time.Time. - Added IsValidNumericDate() helper with maxUnixTimestamp (year 9999) and minUnixTimestamp (1970) constants - verifyExpiresAt, verifyNotBefore, verifyIssuedAt now check for out-of-bounds timestamps and return ErrTokenInvalidClaims - All existing tests continue to pass Fixes heathivorjocelyn6#1
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added validation to reject JWTs with out-of-bounds expiration (
exp), not-before (nbf), and issued-at (iat) values that could causetime.Timeoverflow or undefined behavior.Changes
IsValidNumericDate()helper function withmaxUnixTimestamp(253402300799 = year 9999) andminUnixTimestamp(0 = 1970) boundariesverifyExpiresAt(),verifyNotBefore(), andverifyIssuedAt()— returnsErrTokenInvalidClaimswhen a timestamp is out of boundsAcceptance Criteria
Fixes #1