prometheus: Settings: Fix connection test crash on plain-text response#909
Open
Athang69 wants to merge 1 commit into
Open
prometheus: Settings: Fix connection test crash on plain-text response#909Athang69 wants to merge 1 commit into
Athang69 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Prometheus plugin Settings “Test Connection” flow to avoid JSON parsing crashes by switching from the plain-text /-/healthy endpoint to the JSON-based Prometheus query API, and it adds a basic validation of the Prometheus API response.
Changes:
- Switch connection test endpoint from
/-/healthyto/api/v1/query?query=up(JSON response). - Validate the returned Prometheus payload by checking
response.status === 'success'before reporting success.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Athang69 <athangkali21@gmail.com>
c078688 to
0fc0bb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash in the Prometheus plugin connection test by replacing the plain text /-/healthy health check with a JSON producing query endpoint.
Related Issue
Fixes kubernetes-sigs/headlamp#6541
Changes
Steps to Test
Notes for the Reviewer