tinkerbell: Align UI with v0.23 lab data#895
Open
ayushmaan-16 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Tinkerbell plugin UI and resource typings to match the observed CRD/status shapes from a real Tinkerbell v0.23.0 lab, improving list/detail rendering for Workflows, Hardware, and Templates.
Changes:
- Adjust Workflow resource typing and UI to handle v0.23.0
status.currentStateobject shape and action timing fields (executionStart/executionStop/executionDuration). - Simplify Hardware/Template list + detail views by removing misleading status fields and showing more relevant observed/derived attributes.
- Harden
normalizeStateto safely handle non-string inputs and add a unit test.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tinkerbell/src/resources/workflow.ts | Updates Workflow CRD typings for v0.23.0 status/boot options/action timing fields. |
| tinkerbell/src/resources/common.ts | Makes normalizeState accept unknown and return “Unknown” for non-strings. |
| tinkerbell/src/resources/common.test.ts | Adds test coverage for normalizeState with non-string input. |
| tinkerbell/src/components/workflows/List.tsx | Updates Workflow list columns to use v0.23.0 state/current action/task count derivations. |
| tinkerbell/src/components/workflows/Detail.tsx | Updates Workflow detail rendering for new currentState shape and action timing fields. |
| tinkerbell/src/components/templates/List.tsx | Removes Template status column; focuses list view on template body-derived info. |
| tinkerbell/src/components/templates/Detail.tsx | Improves template action summaries, including conditional alternatives (“action slots”). |
| tinkerbell/src/components/hardware/List.tsx | Removes Hardware status column and improves Agent ID derivation fallback logic. |
| tinkerbell/src/components/hardware/Detail.tsx | Reworks Hardware detail view to surface observed agent attributes and more relevant summary fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use the real v0.23 workflow status shape observed in the Vagrant lab. This prevents detail pages from crashing when currentState is returned as an object. Remove misleading Hardware and Template status fields. Improve Template conditional action summaries and render observed Hardware attributes from agent data. Signed-off-by: ayxsh_shxrma <ayushmaan.sharma911@gmail.com>
ayushmaan-16
force-pushed
the
tinkerbell-lab-ui-fixes
branch
from
4bbcdf9 to
387817f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Tinkerbell plugin UI based on testing against a real
Tinkerbell v0.23.0 Vagrant/VirtualBox lab.
The changes focus on the core Hardware, Template, and Workflow CRDs.
Changes
status.currentStateis an object.executionStart,executionStop, andexecutionDuration.such as
reboot into os/kexec into os.