Skip to content

velero: Add backup coverage panels (Phase 1)#877

Open
Pragati5-DEBUG wants to merge 9 commits into
headlamp-k8s:mainfrom
Pragati5-DEBUG:velero/backup-coverage-phase-1
Open

velero: Add backup coverage panels (Phase 1)#877
Pragati5-DEBUG wants to merge 9 commits into
headlamp-k8s:mainfrom
Pragati5-DEBUG:velero/backup-coverage-phase-1

Conversation

@Pragati5-DEBUG

Copy link
Copy Markdown
Contributor

Introduce a read-only Velero plugin that shows schedule coverage on Deployment, StatefulSet, PVC, and Namespace detail views, with install detection, plugin settings, tests, and manual-test fixtures.

Tracks kubernetes-sigs/headlamp#5198.

@Pragati5-DEBUG Pragati5-DEBUG force-pushed the velero/backup-coverage-phase-1 branch from d6715d5 to a230d35 Compare July 6, 2026 10:15
@itvi-1234

Copy link
Copy Markdown

Could you please break down the commits ?

Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
@Pragati5-DEBUG Pragati5-DEBUG force-pushed the velero/backup-coverage-phase-1 branch from a230d35 to 941501a Compare July 6, 2026 13:20

@itvi-1234 itvi-1234 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look?

Comment thread velero/src/hooks/useVeleroData.ts
Comment thread velero/src/coverage.ts
Comment thread velero/src/coverage.test.ts
Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
@Pragati5-DEBUG

Copy link
Copy Markdown
Contributor Author

@itvi-1234 Thanks for the review!

Documentation: Added JSDoc to the coverage types/helpers and useVeleroData / VeleroDataState.

Testing: npm test passes (13 unit tests). Manually verified on minikube with Velero + fixtures from velero/test-files/ — covered (nginx-demo, web StatefulSet) and not-covered cases. Details in velero/test-files/README.md.

@itvi-1234

Copy link
Copy Markdown

@Pragati5-DEBUG , I think we can also document other files too and add some details

Comment thread velero/package.json Outdated
@Pragati5-DEBUG

Copy link
Copy Markdown
Contributor Author

@itvi-1234 Thanks — want to make sure I match what you have in mind:

  1. package.json description — expand to describe the full Velero plugin (coverage panels on Deployment/STS/PVC/Namespace detail views, read-only Phase 1). OK?

  2. Other file docs — planning JSDoc on the remaining public modules:

    • resources/velero.ts (Schedule/Backup wrappers)
    • useVeleroInstalled.ts
    • config.ts
    • cron.ts

    Anything else you had in mind (e.g. index.tsx, panel components, README)?

Happy to push once you confirm scope. Thanks!

Signed-off-by: Pragati <Pragati5-DEBUG@users.noreply.github.com>
@Pragati5-DEBUG

Copy link
Copy Markdown
Contributor Author

@itvi-1234 Done — pushed an update:

  • package.json description now describes the full Velero plugin (coverage on Deployment/STS/PVC/Namespace detail views, read-only).
  • JSDoc added on resources/velero.ts, config.ts, useVeleroInstalled.ts, cron.ts, index.tsx, BackupCoveragePanelPure, and settings.tsx (in addition to the earlier coverage.ts / useVeleroData.ts docs).

Please take another look when you have time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants