Fix build errors on MSYS platform - #30
Open
carlzhc wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for your contribution. Can you show me a log with the current state of the PR? |
Author
|
Squashed the commits and updated the log. |
Owner
|
Thanks! I know it's working already, but wouldn't it be nice if those |
Author
|
Fixed those |
hboetes
force-pushed
the
master
branch
5 times, most recently
from
February 25, 2026 03:22
34b1b12 to
959f5ee
Compare
Owner
|
I have a feeling you might have missed the notification since I got no answer to the previous one, so where were we? It looks good overall, but a few questions before merging:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... ... (see the attached log file)
build.1712669255.log