fix: miniplayer tap handling on iOS#28
Merged
Merged
Conversation
ThaUnknown
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the miniplayer bug which prevents taps on iOS from being fired thus needing to tap multiple times or tap on a weird specific spot to navigate to the player, The root cause of this was that
pointerdowncould start from the video/canvas inside the miniplayer, butpointerupwas only allowed to finish if it came directly from the wrapper itself. On iOS, the release often stays targeted on the inner video/canvas, so the wrapper never got to finish the tap and open the player.I confirmed this works by testing it locally with safari on both my iPhone and iPad.