You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Methods unset, offsetUnset and remove now delete offset from data and cache array. I used 1. solution from here.
We should now discuss if changing the interface is really such a breaking change. Are there actually any developers who actually implemented their own AbstractConfig? We can probably release as the minor/normal version, but just add in the release notes that interface is changed.
There is a problem with this. Problem is (probably) that unset is keyword so it can't be used as a method name for AbstractConfig in old PHP versions (PHP 5). Fix for this is to rename unset to remove or delete.
There is a problem with this. Problem is (probably) that unset is keyword so it can't be used as a method name for AbstractConfig in old PHP versions (PHP 5). Fix for this is to rename unset to remove or delete.
This will let php-5.5 and php-5.6 can be passed on Travis CI build :).
We should now discuss if changing the interface is really such a breaking change. Are there actually any developers who actually implemented their own AbstractConfig? We can probably release as the minor/normal version, but just add in the release notes that interface is changed.
I think that creating a new major release here is the best choice, but if you think that I'm wrong let's discuss about it. 😄 I'm just trying to adhere to the Semantic Versioning rules for major release:
MAJOR version when you make incompatible API changes
There is a problem with this. Problem is (probably) that unset is keyword so it can't be used as a method name for AbstractConfig in old PHP versions (PHP 5). Fix for this is to rename unset to remove or delete.
I agree that we can rename it to remove for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes unsetting offset. Fixes #123.
Methods
unset,offsetUnsetandremovenow delete offset from data and cache array. I used 1. solution from here.We should now discuss if changing the interface is really such a breaking change. Are there actually any developers who actually implemented their own
AbstractConfig? We can probably release as the minor/normal version, but just add in the release notes that interface is changed.