Add bounded task-to-PR lifecycle contract#38
Closed
andrei-hasna wants to merge 3 commits into
Closed
Conversation
Contributor
Author
|
Terminal NO-GO after repair cycle 2/2. Two fresh exact-head adversarial reviewers independently confirmed P1 blockers in fail-closed validation and lifecycle semantics. No third repair is authorized for this acceptance binding; a new bounded task/PR is required for any redesigned contract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement task
Changed files
Repair-cycle-2 reconciliation
The accepted readable lifecycle is preserved and anchored to one authoritative typed YAML invariant manifest. The previous polarity-blind normalized substring and synonym matrix has been removed. The deterministic validator now locks 11 fail-closed invariant records, allowed and denied states, required relationships, authoritative field bindings, section locations, and exact field policy references. It parses authoritative fenced values across the document, rejects unsafe manifest states, paraphrased field substitutions, cross-section field records, and all 14 rejected-head reviewer probes with invariant-specific violations. Eleven strengthening near-misses, including A reviewer may not merge and The expected-head guard is not optional, remain valid. The skill explicitly limits the proof boundary to typed records and authoritative fenced fields and makes no natural-language inference claim.
Validation
Distribution and rollback
No merge, publish, release, generated-output commit, Instructions edit, live skill distribution, branch deletion, or worktree cleanup is included. Before landing, rollback is to close this unmerged PR. After landing, revert the provider landing commit for the whole PR; repair-cycle-2-only rollback is revert commit b80e163. The task worktree and branch remain preserved for fresh exact-head review and the distinct merge operator.