Skip to content

Add bounded task-to-PR lifecycle contract#38

Closed
andrei-hasna wants to merge 3 commits into
mainfrom
feat/e-00109-task-to-pr-bounded
Closed

Add bounded task-to-PR lifecycle contract#38
andrei-hasna wants to merge 3 commits into
mainfrom
feat/e-00109-task-to-pr-bounded

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Replacement task

  • Todos task: E-00109 / 5cf3bf32-58fc-4869-b926-486ff9d106de
  • Todos plan: a08dc545-512f-43ee-a553-6231a2131c50
  • Parent native plan: 8eadc06b-7276-4854-a6bc-b879866abf6f
  • Parent goal: 32e0d30d-e05a-45ce-9034-dfc9afeefd1d
  • Parent node: e7994834-cd3e-4416-80fc-9e82bb8b59e8
  • Initial implementation child goal, complete provenance: b3e6f91f-87eb-47cb-9108-bbeacdf28bd6
  • Repair-cycle-1 child goal, complete provenance: d3333641-c14c-42f3-9bf5-123a79830976
  • Repair-cycle-2 child goal: 55fbf503-f08c-41b3-a449-be40c9eaced9
  • Predecessor: closed PR Add canonical task-to-PR lifecycle skill #36 / task c4256422-07de-4ac7-9b2a-e4af3be7fc9e
  • Acceptance scope: skills-task-to-pr-split-v1
  • Risk tier: elevated
  • Subscription profile alias: account002
  • Repair run: 49c10b95-0894-4f1f-8d69-1b5f3717900c
  • Writer generation: c7415957-253a-4062-a866-eff5c3e8e629
  • Attempt nonce: e78c3608-4b2b-4b52-a631-4de6974d8f8a
  • Cumulative repair count: 2 of 2
  • Remaining repair capacity: 0 cycles; no third repair or re-review cycle
  • Previous rejected heads: bdf5615 and 9494386
  • Exact repaired head: b80e163
  • Exact failed reviewers: codewith-account006/account008 at repair count 0 and codewith-account003/account013 at repair count 1

Changed files

  • agent-skills/task-to-pr-lifecycle/SKILL.md
  • src/lib/task-to-pr-lifecycle-skill.test.ts

Repair-cycle-2 reconciliation

The accepted readable lifecycle is preserved and anchored to one authoritative typed YAML invariant manifest. The previous polarity-blind normalized substring and synonym matrix has been removed. The deterministic validator now locks 11 fail-closed invariant records, allowed and denied states, required relationships, authoritative field bindings, section locations, and exact field policy references. It parses authoritative fenced values across the document, rejects unsafe manifest states, paraphrased field substitutions, cross-section field records, and all 14 rejected-head reviewer probes with invariant-specific violations. Eleven strengthening near-misses, including A reviewer may not merge and The expected-head guard is not optional, remain valid. The skill explicitly limits the proof boundary to typed records and authoritative fenced fields and makes no natural-language inference claim.

Validation

  • bun test src/lib/task-to-pr-lifecycle-skill.test.ts repeated three times: 27 passed, 267 assertions
  • relevant agent-skill tests: 14 passed, 111 assertions
  • bun run typecheck: passed
  • home-isolated full suite: 736 passed, 9,820 assertions
  • isolated bun run build: passed
  • scripts/check_skill_corpus_drift.sh --base origin/main: passed
  • npm pack --dry-run --json --ignore-scripts: passed, 1,359 files
  • bun run verify:release: passed
  • git diff --check and exact repair/cumulative two-file diff: passed
  • non-printing staged, repair-range, and cumulative gitleaks scans: passed
  • labeled adversarial self-review replayed both exact fail artifacts, every unsafe reviewer probe, safe negations, paraphrased typed/field substitutions, cross-section placement, and fenced route/completion/merge substitutions: P0 none, P1 none, P2 none
  • provider-native exact-head CI: passed, run 30020813584 / job 89252732327 for b80e163

Distribution and rollback

No merge, publish, release, generated-output commit, Instructions edit, live skill distribution, branch deletion, or worktree cleanup is included. Before landing, rollback is to close this unmerged PR. After landing, revert the provider landing commit for the whole PR; repair-cycle-2-only rollback is revert commit b80e163. The task worktree and branch remain preserved for fresh exact-head review and the distinct merge operator.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Terminal NO-GO after repair cycle 2/2. Two fresh exact-head adversarial reviewers independently confirmed P1 blockers in fail-closed validation and lifecycle semantics. No third repair is authorized for this acceptance binding; a new bounded task/PR is required for any redesigned contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant