fix: rebrand Open Skills to Hasna Skills, scrub internal domain/infra leak#34
Open
andrei-hasna wants to merge 1 commit into
Open
fix: rebrand Open Skills to Hasna Skills, scrub internal domain/infra leak#34andrei-hasna wants to merge 1 commit into
andrei-hasna wants to merge 1 commit into
Conversation
…fra references Renames the "Open Skills" product name to "Hasna Skills" in user-facing copy (README, CONTRIBUTING, CLI storage output, source headers) without touching the open-skills identifiers, repo name, or package name. Also removes an internal-infra leak: the default self-hosted API origin, docs, and tests hardcoded the internal skills.hasna.xyz domain and a real AWS account ID/role ARN in the production deploy workflow. Replaces the hosted/default references with the public skills.md domain, replaces generic self-hosted examples with neutral placeholders, and moves the AWS account ID out of the workflow file into a GitHub Actions secret reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storageoutput text, source file headers). Does not touch theopen-skillsidentifiers, thehasna/skillsrepo name, the@hasna/skillspackage name, or theopen sourcephrase.skills.hasna.xyzdomain was hardcoded as the CLI's default self-hosted API origin (DEFAULT_SELF_HOSTED_API_URL), in README examples, in architecture/product docs, and in several test fixtures. Hosted/default references now point at the publicskills.mddomain (matching the existing"skills.md": "self-hosted"alias already insrc/lib/config.ts); generic "point at your own self-hosted registry" examples now use a neutral placeholder (https://your-server.example/example.com) instead of a real-looking internal host..github/workflows/deploy.yml: removed the hardcoded real AWS account ID from the workflowenv:block and switched the IAM role-to-assume ARN to read the account ID from asecrets.AWS_ACCOUNT_IDGitHub Actions secret instead of a plaintext value in the repo. Updated the smoke-test health check domain toskills.mdto match the new default.Not done (needs a human/operator decision, flagged rather than guessed)
AWS_ACCOUNT_IDGitHub secret must be added to this repo before this workflow will function — I removed the plaintext value from the file but did not (and should not, as an automated change) provision the actual secret. Deploys will fail closed until an admin adds it..github/workflows/deploy.ymloutright (one option raised during review). It's the production deploy workflow (push: branches: [main]-> real ECS/Fargate deploy); removing it would disable production deploys unless an equivalent pipeline already exists elsewhere. That's an availability decision outside what this PR should decide unilaterally./hasna/deploy/${APP}SSM parameter naming convention indeploy.ymlwas left as-is — low-sensitivity naming detail (not a credential), using the existing non-secretAPPenv var.Test plan
bun installbun run build(CLI, MCP, server, worker, migrate, library all bundle cleanly)bun test— 727 pass, 0 failOpen Skills,hasna.xyz, or the literal AWS account ID