fix(security): remove internal infra hostnames from published package#11
Open
andrei-hasna wants to merge 1 commit into
Open
fix(security): remove internal infra hostnames from published package#11andrei-hasna wants to merge 1 commit into
andrei-hasna wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/http-store.ts: neutralized the illustrativehttps://identities.hasna.xyzexample in a doc comment tohttps://identities.your-deployment.example.src/http-store.test.ts: updated the corresponding test fixtures to the same neutral placeholder.Why
Public npm package
@hasna/identitiesreferenced a real internal hostname convention in a doc-comment example and matching test fixtures. Note: on inspection,resolveCloudHttpConfig()already requires bothHASNA_IDENTITIES_API_URLandHASNA_IDENTITIES_API_KEYto be explicitly set — there is no silent default-hostname fallback in the actual runtime code. This PR only removes the illustrative internal-hostname string from comments/tests; no behavior changes.Out of scope (flagged, not changed)
src/roster.tsand the generatedagents/hasna/**/*.mdfiles intentionally reference<agent>@hasna.xyzas the canonical internal AI-agent-mailbox convention. That is this package's core product feature (generating the company's agent roster with vanity@hasna.xyzaddresses), not a leaked default endpoint, so it was left untouched. Flagging for awareness in case a broader policy review wants to reconsider shipping that convention publicly.Test plan
bun run typecheck— cleanbun test src/http-store.test.ts— 14/14 passbun test(full suite) — 64 pass / 0 fail