Skip to content

fix: exempt bundled dist artifacts from no-cloud self-scan (0.4.2) #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrei-hasna wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: exempt bundled dist artifacts from no-cloud self-scan (0.4.2) #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hasna/contracts",
"version": "0.4.1",
"version": "0.4.2",
"description": "Shared schemas and validators for Hasna open-source agent infrastructure contracts.",
"type": "module",
"license": "Apache-2.0",
Expand Down
23 changes: 11 additions & 12 deletions src/no-cloud.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,14 @@ const DECLARATION_FILE_MARKERS = [
"hasna.app_cloud_manifest.v1",
"hasna.no_cloud_evidence_pack.v1"
] as const;
const CONTRACTS_DECLARATION_PATHS = new Set([
"src/no-cloud.ts",
"src/schemas.ts",
"dist/no-cloud.js",
"dist/schemas.js",
"dist/validators.js",
"dist/index.js",
"dist/cli/index.js",
"dist/no-cloud.d.ts",
"dist/schemas.d.ts"
]);
// The forbidden-runtime pattern strings legitimately live in exactly two source
// modules. Any file under dist/ is a build artifact derived from those sources;
// bundlers inline the declaration content into whichever entrypoints import it,
// so the exact set of dist files carrying it changes with the build config.
// Match the two sources explicitly and treat any dist/ artifact generically —
// the >= 2 declaration-marker gate below (plus the @hasna/contracts package gate)
// keeps downstream packages from bypassing the scan.
const CONTRACTS_DECLARATION_SOURCES = new Set(["src/no-cloud.ts", "src/schemas.ts"]);

function stableId(input: string) {
let hash = 0;
Expand Down Expand Up @@ -169,7 +166,9 @@ function isAppCloudManifestDocument(file: ScanFile): boolean {
function isNoCloudDeclarationFile(file: ScanFile, packageName?: string): boolean {
if (packageName !== "@hasna/contracts") return false;
const normalized = file.path.replaceAll("\\", "/");
if (!CONTRACTS_DECLARATION_PATHS.has(normalized)) return false;
const isDeclarationSource = CONTRACTS_DECLARATION_SOURCES.has(normalized);
const isBuildArtifact = normalized === "dist" || normalized.startsWith("dist/");
if (!isDeclarationSource && !isBuildArtifact) return false;
if (!/\.(cjs|cts|js|jsx|mjs|mts|ts|tsx)$/i.test(normalized)) return false;
const markerCount = DECLARATION_FILE_MARKERS.filter((marker) => file.text.includes(marker)).length;
return markerCount >= 2;
Expand Down
2 changes: 1 addition & 1 deletion src/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { z } from "zod";

export const CONTRACTS_PACKAGE_NAME = "@hasna/contracts";
export const CONTRACTS_PACKAGE_VERSION = "0.4.1";
export const CONTRACTS_PACKAGE_VERSION = "0.4.2";

export const SCHEMA_IDS = {
actorRef: "hasna.actor_ref.v1",
Expand Down
Loading