Fix Solcast auth/profile blockers from #317#319
Merged
andrei-hasna merged 4 commits intoJul 7, 2026
Merged
Conversation
Implement @hasna/connect-solcast with API client, CLI, types, registry entry, and focused client tests against the public Solcast REST API.
Add Environment Variables, CLI Commands, and Data Storage sections for dashboard auth detection; wire install_date and terrain_shading options.
andrei-hasna
force-pushed
the
openloops/open-connectors/9f9e2607-ec11-4409-99d2-650cb81ae86f-6d47e909
branch
from
July 7, 2026 08:44
1e5f68f to
a5c5022
Compare
andrei-hasna
force-pushed
the
openloops/open-connectors/9f9e2607-ec11-4409-99d2-650cb81ae86f-6d47e909
branch
from
July 7, 2026 08:47
a5c5022 to
d8c9e80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webhooksalias expected by the current test suite with @hasna/events channel commandsReferences blocked PR #317 and todos task 9f9e2607-ec11-4409-99d2-650cb81ae86f. Parent review task: 4ccddb87-e262-42a8-8724-cdc7b8742b9f.
Validation
HOME=/tmp/open-connectors-solcast-home TMPDIR=/tmp bun test connectors/solcast/src/api/client.test.ts connectors/solcast/src/utils/config.test.ts-> 10 pass, 0 failrm -rf /tmp/open-connectors-auth-home && mkdir -p /tmp/open-connectors-auth-home && HOME=/tmp/open-connectors-auth-home TMPDIR=/tmp bun test src/server/server-auth.test.ts src/lib/runner-auth.test.ts-> 60 pass, 0 failbun run typecheck-> passbun run build-> passcd connectors/solcast && bun run typecheck && bun run build-> passrm -rf /tmp/open-connectors-test-home && mkdir -p /tmp/open-connectors-test-home && HOME=/tmp/open-connectors-test-home TMPDIR=/tmp bun test-> 1201 pass, 0 failgit diff --cached --check-> passReview
Independent adversarial review found and the commit fixes: legacy fallback credentials not cleared, baseUrl-only Solcast profiles falsely authenticated, and AWS-style credential env vars no longer counting as configured.
GitHub author is andrei-hasna
GitHub reviewer pool: andrei-hasna, kriptoburak
Selected non-author reviewer: kriptoburak