Skip to content

switched dangerous default arguments to None#635

Open
shayneofficer wants to merge 2 commits into
hasgeek:mainfrom
shayneofficer:so-dangerous-defaults
Open

switched dangerous default arguments to None#635
shayneofficer wants to merge 2 commits into
hasgeek:mainfrom
shayneofficer:so-dangerous-defaults

Conversation

@shayneofficer

Copy link
Copy Markdown

Per the code sniff here using mutable lists/dictionaries as default arguments is a bug risk.

@shayneofficer shayneofficer deleted the so-dangerous-defaults branch October 16, 2021 20:20
@jace

jace commented Oct 21, 2021

Copy link
Copy Markdown
Member

Hi, I was on holiday and missed this. I’m not sure why you’ve closed the PR. In any case, I’ve implemented similar fixes in #637.

@shayneofficer shayneofficer restored the so-dangerous-defaults branch October 21, 2021 11:57
@shayneofficer

Copy link
Copy Markdown
Author

Hi @jace ! no worries, thanks for the response 😄 I closed it since one of the build pipeline checks said I introduced a new bug I think - happy to re-open if you think this change is valuable though!

@shayneofficer shayneofficer reopened this Oct 21, 2021
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants