fix: LHv2: don't use BDF paths when driver set to 'aio'#281
Open
tserong wants to merge 1 commit into
Open
Conversation
The Longhorn V2 aio bdev driver needs a regular device path to a disk (e.g. "/dev/whatever"), but currently NDM will always try to use BDF paths for NVMe or virtio devices even if the disk driver is set to aio. In this case, Longhorn just doesn't know what to do and can't add the disk. We can fix this by ensuring NDM doesn't try to resolve BDF paths if the disk driver is set to aio. Related-to: harvester/harvester#10666 Signed-off-by: Tim Serong <tserong@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The Longhorn V2 aio bdev driver needs a regular device path to a disk (e.g. "/dev/whatever"), but currently NDM will always try to use BDF paths for NVMe or virtio devices even if the disk driver is set to aio. In this case, Longhorn just doesn't know what to do and can't add the disk.
Solution:
We can fix this by ensuring NDM doesn't try to resolve BDF paths if the disk driver is set to aio.
Related Issue:
harvester/harvester#10666
Test plan:
TBD