docs: shell-startup module-placement convention + audit follow-ups#307
Merged
Conversation
…ow-ups Resolves two coupled shell-startup TODO items: (1) write down the "env-vs-bin" module-placement convention (rubric + hygiene) in .claude/CONVENTIONS.md, where it was previously unwritten though it drove several audit decisions; (2) the per-module env-pollution audit of config/shell-startup/ — its actionable findings become concrete TODO items (ansible/calibre/claude/binenv moves, perl/ ssh-config-completion hygiene), and the aider item is reframed to fold into the AGENTS.md migration rather than a bin/aider wrapper (aider reads AGENTS.md). Full per-module report is in the PR description. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merge-time finalization: remove the two [x] items delivered by this PR (the module-placement convention → .claude/CONVENTIONS.md, and the per-module audit → PR description + follow-up items). Planning doc holds only open work. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
harleypig
force-pushed
the
docs/shell-startup-module-placement
branch
from
July 23, 2026 16:43
c4fea0d to
1e4cf14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/CONVENTIONS.md(the "env-vs-bin split" rubric + hygiene rules) — previously unwritten though
it drove audit decisions.
TODO.mdfollow-ups(moves + hygiene) and marks the two delivered items done.
audit/BACKLOG.md) instead of abin/aiderwrapper — aider reads AGENTS.md.Per-module audit report (the deliverable)
Load model: every module is sourced for both interactive and non-interactive
login shells; no global interactivity guard, so each self-guards interactive
content with
[[ $- == *i* ]] || return 0, and any bareexporthits every shell.aider(AIDER_*,AIDER_EDITOR,AIDER_COMMIT_PROMPT); flagclaude(CLAUDE_CONFIG_DIR,CLAUDE_CODE_NO_FLICKER)ansible(+ siblings viabin/_ansible-env),calibre(or fold intoapp_env_vars),claude(verifyCLAUDE_CONFIG_DIRconsumers first)binenv— env→wrapper; gate + vendor completion (config/completions/binenv) to stop the per-shell forktmux(dropexport -f; unsetcircled_digits),perl(unset -fsetup fns),ssh-config-completion(localin_ssh)000-loadtokens,010-general,app_env_vars,less,vim,go,python,node,cuda,jbang,bash_prompt,git,docker,gh,rust,terraform,grok,zzz-check-dotfiles,zzz-check-dotvim(both silent on happy path),taskwarrior_inactive(disabled)Test plan
TODO.mdholds only open work after merge-finalization prunes the[x]items.