Skip to content

Add COPYRIGHT & fix issue with shutterspeed >1sec#1

Open
whaan wants to merge 11 commits into
haozhexu:masterfrom
whaan:master
Open

Add COPYRIGHT & fix issue with shutterspeed >1sec#1
whaan wants to merge 11 commits into
haozhexu:masterfrom
whaan:master

Conversation

@whaan

@whaan whaan commented Dec 20, 2024

Copy link
Copy Markdown

One improvement and three bug fixes

Add optional © COPYRIGHT

  • move "CUSTOM_TEXT" to top-center (as the title of the photo)
  • place COPYRIGHT bottom-right

Use magick instead of convert to be compatible with the latest version of imagemagick

"magick" by itself uses IM v7 syntax. "magick convert" uses the older v6 syntax.
Differences between v6 and v7 syntax are shown on https://www.imagemagick.org/script/porting.php .
V7 syntax is better than v6. It is more powerful, with new features, and has improved error-checking. I suggest that "magick convert" is used only when if you have an old v6 script that doesn't work under v7.
Put it another way: "magick convert" is provided for backwards compatibility. For new work, "magick" should be used.
ImageMagick/ImageMagick#5279 (comment)

Also we now use identify instead of convert -ping

Fix issue with shutterspeeds of longer than 1 sec.

When shutters-eed is more than 1 second, it's not displayed right.
By first checking if it's longer than 1sec, we can print it correctly

Support Camera Models with a space in the name

My camera model is Nikon D7500, but only the first part (Nikon) was printed in the border.
Now we use a separate identify to fetch the cameramodel from the exif which fixes that issue

whaan and others added 11 commits December 20, 2024 13:58
move CUSTOM_TEXT" to top-center
place COPYRIGHT bottom-right
- add CUSTOM TEXT
- add COPYRIGHT
- update "Example with all options specified"
- improve calculation of OFFSET_T
- use `identify` instead of `magick -ping`
- use a separate `identify` to accomodate for spaces in the camera model
- remove duplacate "sec"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant