Add COPYRIGHT & fix issue with shutterspeed >1sec#1
Open
whaan wants to merge 11 commits into
Open
Conversation
"magick" uses IM v7 syntax ImageMagick/ImageMagick#5279 (comment)
move CUSTOM_TEXT" to top-center place COPYRIGHT bottom-right
- add CUSTOM TEXT - add COPYRIGHT - update "Example with all options specified"
- improve calculation of OFFSET_T - use `identify` instead of `magick -ping` - use a separate `identify` to accomodate for spaces in the camera model - remove duplacate "sec"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One improvement and three bug fixes
Add optional © COPYRIGHT
Use
magickinstead ofconvertto be compatible with the latest version ofimagemagickAlso we now use
identifyinstead ofconvert -pingFix issue with shutterspeeds of longer than 1 sec.
When shutters-eed is more than 1 second, it's not displayed right.
By first checking if it's longer than 1sec, we can print it correctly
Support Camera Models with a
spacein the nameMy camera model is
Nikon D7500, but only the first part (Nikon) was printed in the border.Now we use a separate
identifyto fetch thecameramodelfrom the exif which fixes that issue