Skip to content

[codex] Centralize release install resolution#17

Merged
halkn merged 1 commit into
mainfrom
feat/improve-desgin
Apr 24, 2026
Merged

[codex] Centralize release install resolution#17
halkn merged 1 commit into
mainfrom
feat/improve-desgin

Conversation

@halkn

@halkn halkn commented Apr 24, 2026

Copy link
Copy Markdown
Owner

What changed

  • Introduced InstallPlan to carry resolved release installation data
  • Centralized external release resolution in resolver.py
  • Updated commands.py to compare and execute updates based on resolved plans
  • Simplified installer.py so release installs consume resolved plans instead of re-fetching release metadata
  • Reduced duplicate GitHub release access when auto-selecting release assets
  • Added and updated tests for resolver, commands, and installer flows

Why

The previous flow mixed external release resolution across commands.py, resolver.py, and installer.py. That made the update path harder to reason about and caused redundant release metadata lookups in some GitHub release flows.

Impact

  • Clarifies responsibility boundaries between resolution and installation
  • Makes future performance work easier by concentrating release lookups in one place
  • Reduces duplicate external access for GitHub release resolution when asset selection is automatic

Validation

  • uv run pytest tests/test_resolver.py tests/test_commands.py tests/test_installer.py
  • uv run ruff check src tests

@halkn halkn marked this pull request as ready for review April 24, 2026 22:38
@halkn halkn merged commit b6e7f54 into main Apr 24, 2026
1 check passed
@halkn halkn deleted the feat/improve-desgin branch April 25, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant