Skip to content

XS✔ ◾ fix app version label when image tag is overridden#9

Merged
dimoschi merged 1 commit into
mainfrom
typesense/fix-effective-app-version
Apr 28, 2026
Merged

XS✔ ◾ fix app version label when image tag is overridden#9
dimoschi merged 1 commit into
mainfrom
typesense/fix-effective-app-version

Conversation

@dimoschi
Copy link
Copy Markdown
Collaborator

Summary

Use the effective Typesense image version for app.kubernetes.io/version instead of always using Chart.appVersion.

Changes

  • add a helper for the effective app version
  • use it in the common labels helper
  • add a regression test for overridden image.tag

Validation

  • mise run test
  • mise run lint

@github-actions
Copy link
Copy Markdown

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 10
Test Code 12
Subtotal 22
Ignored Code -
Total 22

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title fix app version label when image tag is overridden XS✔ ◾ fix app version label when image tag is overridden Apr 28, 2026
@github-actions
Copy link
Copy Markdown

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 10
Test Code 12
Subtotal 22
Ignored Code -
Total 22

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@dimoschi dimoschi marked this pull request as ready for review April 28, 2026 14:22
@dimoschi dimoschi requested a review from a team as a code owner April 28, 2026 14:22
@dimoschi dimoschi merged commit 6dce139 into main Apr 28, 2026
3 checks passed
@dimoschi dimoschi deleted the typesense/fix-effective-app-version branch April 28, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants