Skip to content

Fix Service appProtocol values#8

Merged
dimoschi merged 3 commits into
mainfrom
typesense/fix-appProtocol
Apr 28, 2026
Merged

Fix Service appProtocol values#8
dimoschi merged 3 commits into
mainfrom
typesense/fix-appProtocol

Conversation

@dimoschi
Copy link
Copy Markdown
Collaborator

@dimoschi dimoschi commented Apr 28, 2026

Summary

Fix the appProtocol values in the rendered Services so they match the actual traffic.

Why

1.1.2 set incorrect protocols in templates/service.yaml, which can break integrations that rely on the Service protocol hints.

Changes

  • set the routed Service appProtocol to http
  • set the headless Service appProtocol to tcp
  • update tests, docs, schema, and chart version

@github-actions
Copy link
Copy Markdown

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code 3
Test Code 3
Subtotal 6
Ignored Code 121
Total 127

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions Bot changed the title [codex] fix Service appProtocol values XS✔ ◾ [codex] fix Service appProtocol values Apr 28, 2026
@dimoschi dimoschi changed the title XS✔ ◾ [codex] fix Service appProtocol values Fix Service appProtocol values Apr 28, 2026
@dimoschi dimoschi marked this pull request as ready for review April 28, 2026 14:05
@dimoschi dimoschi requested a review from a team as a code owner April 28, 2026 14:05
@dimoschi dimoschi merged commit 250c960 into main Apr 28, 2026
3 checks passed
@dimoschi dimoschi deleted the typesense/fix-appProtocol branch April 28, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants